-
Notifications
You must be signed in to change notification settings - Fork 2
fix: sync search data when groups or projects are removed #1075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You can access the deployment of this PR at https://renku-ci-ds-1075.dev.renku.ch |
b3693f8 to
d2a5da4
Compare
Pull Request Test Coverage Report for Build 19105345323Details
💛 - Coveralls |
leafty
reviewed
Oct 24, 2025
leafty
reviewed
Oct 27, 2025
Member
leafty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution looks good to me 👍 .
leafty
previously approved these changes
Oct 29, 2025
401eb6e to
0ded9e6
Compare
leafty
previously approved these changes
Oct 31, 2025
When deleting a project, contained data connectors should be deleted as well. This is currently handled by a trigger in the db watching the `entity_slugs` table.
Removes the trigger that did this before and implements it into the corresponding repositories
0ded9e6 to
abc85e6
Compare
leafty
approved these changes
Nov 6, 2025
Contributor
|
Tearing down the temporary RenkuLab deployment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When projects or groups are removed, the containing entities are removed as well. This wasn't propagated to the search engine. Deleting users does not apply, because this is not implemented yet (in case they have data).
/deploy