Skip to content

Conversation

@eikek
Copy link
Member

@eikek eikek commented Oct 23, 2025

When projects or groups are removed, the containing entities are removed as well. This wasn't propagated to the search engine. Deleting users does not apply, because this is not implemented yet (in case they have data).

/deploy

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-1075.dev.renku.ch

@eikek eikek force-pushed the eikek/931-entity-removal-search branch from b3693f8 to d2a5da4 Compare October 23, 2025 13:26
@coveralls
Copy link

coveralls commented Oct 23, 2025

Pull Request Test Coverage Report for Build 19105345323

Details

  • 39 of 39 (100.0%) changed or added relevant lines in 6 files are covered.
  • 19 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.02%) to 86.829%

Files with Coverage Reduction New Missed Lines %
components/renku_data_services/data_connectors/doi/metadata.py 2 70.67%
components/renku_data_services/namespace/blueprints.py 2 97.56%
components/renku_data_services/k8s/db.py 3 90.98%
components/renku_data_services/storage/blueprints.py 4 91.06%
components/renku_data_services/k8s/watcher/core.py 8 80.13%
Totals Coverage Status
Change from base Build 19095570234: -0.02%
Covered Lines: 22817
Relevant Lines: 26278

💛 - Coveralls

@eikek eikek linked an issue Oct 23, 2025 that may be closed by this pull request
@eikek eikek marked this pull request as ready for review October 24, 2025 05:37
@eikek eikek requested review from a team, SalimKayal and sgaist as code owners October 24, 2025 05:37
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution looks good to me 👍 .

leafty
leafty previously approved these changes Oct 29, 2025
@eikek eikek force-pushed the eikek/931-entity-removal-search branch from 401eb6e to 0ded9e6 Compare October 30, 2025 16:13
leafty
leafty previously approved these changes Oct 31, 2025
@eikek eikek force-pushed the eikek/931-entity-removal-search branch from 0ded9e6 to abc85e6 Compare November 5, 2025 14:29
@eikek eikek requested a review from leafty November 6, 2025 09:19
@eikek eikek merged commit 65cb402 into main Nov 6, 2025
35 checks passed
@eikek eikek deleted the eikek/931-entity-removal-search branch November 6, 2025 10:29
@RenkuBot
Copy link
Contributor

RenkuBot commented Nov 6, 2025

Tearing down the temporary RenkuLab deployment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some entity removal does not update the search

5 participants